Compatibility with frozen Object prototype#2773
Open
norbertsuski wants to merge 2 commits intoiamkun:devfrom
Open
Compatibility with frozen Object prototype#2773norbertsuski wants to merge 2 commits intoiamkun:devfrom
norbertsuski wants to merge 2 commits intoiamkun:devfrom
Conversation
norbertsuski
commented
Nov 19, 2024
norbertsuski
commented
- Freezing the global Object prototype is one of the best ways to defend against Prototype Pollution attacks
- Doing this changes all properties of the Object prototype to become non-writable
- JavaScript does not allow you to use the "=" assignment operator to "shadow" any inherited, non-writable object properties -- in particular, the "toString" property
- The correct way to do this is to use the Object.defineProperty() syntax instead
Ghostz14
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.